This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.
- From: Alistair Francis <alistair23 at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 2 Oct 2019 11:27:05 -0700
- Subject: Re: [PATCH v2 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.
- References: <20190927234133.1046-1-alistair.francis@wdc.com> <alpine.DEB.2.21.1909301524270.13738@digraph.polyomino.org.uk> <CAKmqyKMR2K9XMBoJ6Qh67g8h2efoUABViFR3oBX2s23-7hXMdQ@mail.gmail.com> <alpine.DEB.2.21.1910021627560.28156@digraph.polyomino.org.uk>
On Wed, Oct 2, 2019 at 9:30 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> This appears to have broken the testsuite for all platforms. How was it
> tested?
Argh, I ran the tests on the wrong thing.
>
> FAIL: conform/POSIX2008/arpa/inet.h/conform
> FAIL: conform/POSIX2008/netdb.h/conform
> FAIL: conform/POSIX2008/netinet/in.h/conform
> FAIL: conform/UNIX98/arpa/inet.h/conform
> FAIL: conform/UNIX98/netdb.h/conform
> FAIL: conform/UNIX98/netinet/in.h/conform
> FAIL: conform/XOPEN2K/arpa/inet.h/conform
> FAIL: conform/XOPEN2K/netdb.h/conform
> FAIL: conform/XOPEN2K/netinet/in.h/conform
> FAIL: conform/XOPEN2K8/arpa/inet.h/conform
> FAIL: conform/XOPEN2K8/netdb.h/conform
> FAIL: conform/XOPEN2K8/netinet/in.h/conform
> FAIL: conform/XPG42/arpa/inet.h/conform
> FAIL: conform/XPG42/netdb.h/conform
> FAIL: conform/XPG42/netinet/in.h/conform
>
> By keeping <endian.h> in networking headers, while removing __USE_MISC
> conditionals from that header, it introduces namespace violations to the
> networking headers in all standards modes. You'll need to restore the
> __USE_MISC conditionals in <endian.h>.
I just sent the patch, it fixes the failures. Sorry about the regression
Alistair
>
> --
> Joseph S. Myers
> joseph@codesourcery.com