This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Alistair Francis <alistair23 at gmail dot com>
- Cc: Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 2 Oct 2019 16:30:07 +0000
- Subject: Re: [PATCH v2 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.
- Ironport-sdr: 8a24cO5+NbUi9ZKEw4m3vJgIJ+NhEimAZQ0xsrSbNmO8qjmKprKVZvhY44bGmdmLHPjI0+6LBs RGAYYW4MXG/p/fHkVE9ianYap+fgrSPlsTFjXQ1gorkmaujgcZwg1uSdswwObL+AI6yNAjMO+y HKmpBQgXTPHrEJiNdObgS1F9nwMHvShzGFsOcjp62U/kTbCh0IuUF0jdvr8wHpaEvUiMqCIExM pWkWnPOLi16fXDpBTlko7VpqsK4C22dCQMBiLWo+z+Zm+c8pYLLjJgEBOc8rYo87NOisyXv7QP 2zs=
- Ironport-sdr: d/VsJWY/Jdi5rJWuUCUCNXsJ5JQV2vnktpzUxiRXlI7LrXuizHcIvdMgNvjfmiyPw28uj+pSW9 47/PqJxdW3IKnmFq7niHy8tvgZFwd8EQhbZnE8O+nDRojqUfrONQ5dDbRhdcDBSQtCyJVk5Hbj HCVuX6WP+wce/QMWLKujPBLP4whgOtENEg+X3HkdDf0rbgGV/j1oklZ9bWEb1WHVCev32+d5To taRa3eTJONP6+dxvKTaRZ8juL67pR7zP3XJNhJitc/InyjcfaWUS/aKE29jos0uSm2BMCMkJvQ wpg=
- References: <20190927234133.1046-1-alistair.francis@wdc.com> <alpine.DEB.2.21.1909301524270.13738@digraph.polyomino.org.uk> <CAKmqyKMR2K9XMBoJ6Qh67g8h2efoUABViFR3oBX2s23-7hXMdQ@mail.gmail.com>
This appears to have broken the testsuite for all platforms. How was it
tested?
FAIL: conform/POSIX2008/arpa/inet.h/conform
FAIL: conform/POSIX2008/netdb.h/conform
FAIL: conform/POSIX2008/netinet/in.h/conform
FAIL: conform/UNIX98/arpa/inet.h/conform
FAIL: conform/UNIX98/netdb.h/conform
FAIL: conform/UNIX98/netinet/in.h/conform
FAIL: conform/XOPEN2K/arpa/inet.h/conform
FAIL: conform/XOPEN2K/netdb.h/conform
FAIL: conform/XOPEN2K/netinet/in.h/conform
FAIL: conform/XOPEN2K8/arpa/inet.h/conform
FAIL: conform/XOPEN2K8/netdb.h/conform
FAIL: conform/XOPEN2K8/netinet/in.h/conform
FAIL: conform/XPG42/arpa/inet.h/conform
FAIL: conform/XPG42/netdb.h/conform
FAIL: conform/XPG42/netinet/in.h/conform
By keeping <endian.h> in networking headers, while removing __USE_MISC
conditionals from that header, it introduces namespace violations to the
networking headers in all standards modes. You'll need to restore the
__USE_MISC conditionals in <endian.h>.
--
Joseph S. Myers
joseph@codesourcery.com