This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] S390: Fix undefined symbol "my_waitpid"
- From: Pedro Alves <palves at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org, Ulrich dot Weigand at de dot ibm dot com, Luis Machado <lgustavo at codesourcery dot com>
- Date: Wed, 18 Sep 2013 19:39:19 +0100
- Subject: Re: [PATCH] S390: Fix undefined symbol "my_waitpid"
- Authentication-results: sourceware.org; auth=none
- References: <201309101507 dot r8AF7tHq012141 at d06av02 dot portsmouth dot uk dot ibm dot com>
On 09/10/2013 04:07 PM, Ulrich Weigand wrote:
>> Fix the S390 build. When linux-waitpid.o was introduced (see
>> http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was
>> forgotten to add it to s390.mh; so that's what this patch does.
>
> This happens every now and then, most likely because the s390
> files do not have -linux- in their name, unlike all the other
> Linux target files.
Eh, twice in a couple weeks. A similar thing happened with the
cris-linux port just recently:
https://sourceware.org/ml/gdb-patches/2013-09/msg00076.html
Because it didn't have a -linux- file. We ended up
adding a cris-linux-tdep.c file.
> At some point, it would probably be good to change this. (Maybe
> once we're off CVS and can actually do renames without losing
> history ...)
If the cvs rm + cvs add are done in the same commit, AFAIK,
git will identify it as a rename, so we could do it now even, IMO.
--
Pedro Alves