This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [patch v4 07/24] record-btrace: optionally indent function call history
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Himpel, Christian" <christian dot himpel at intel dot com>
- Date: Tue, 10 Sep 2013 13:06:00 +0000
- Subject: RE: [patch v4 07/24] record-btrace: optionally indent function call history
- Authentication-results: sourceware.org; auth=none
- References: <1372842874-28951-1-git-send-email-markus dot t dot metzger at intel dot com> <1372842874-28951-8-git-send-email-markus dot t dot metzger at intel dot com> <20130818190623 dot GF24153 at host2 dot jankratochvil dot net>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Jan Kratochvil
> Sent: Sunday, August 18, 2013 9:06 PM
Thanks for your review.
> > + else
> > + ui_out_field_string (uiout, "function", "<unknown>");
>
> Here should be _("<unknown>"). (BTW I do not know about any existing
> localized message catalogs for GDB.)
>
> _() would be inappropriate for MI but in such case there should be IMO
> anyway
> rather:
>
> else if (!ui_out_is_mi_like_p (uiout))
> ui_out_field_string (uiout, "function", _("<unknown>"));
>
> But there is currently no MI interface setup for these commands (although
> you have nicely prepared the commands for MI) so I do not find it worth the
> time to discuss MI issues now.
I changed it like you proposed above with no output for MI.
What should we do with text output like "inst" and "at" below.
> > + ui_out_text (uiout, "\tinst ");
Would I split this to separate "inst" from the formatting?
Or is it OK to just say '_("\tinst ")'?
Thanks,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052