This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [patch v4 07/24] record-btrace: optionally indent function call history


> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Jan Kratochvil
> Sent: Sunday, August 18, 2013 9:06 PM

Thanks for your review.


> > +      else
> > +	ui_out_field_string (uiout, "function", "<unknown>");
> 
> Here should be _("<unknown>").  (BTW I do not know about any existing
> localized message catalogs for GDB.)
> 
> _() would be inappropriate for MI but in such case there should be IMO
> anyway
> rather:
> 
>   else if (!ui_out_is_mi_like_p (uiout))
>     ui_out_field_string (uiout, "function", _("<unknown>"));
> 
> But there is currently no MI interface setup for these commands (although
> you have nicely prepared the commands for MI) so I do not find it worth the
> time to discuss MI issues now.

I changed it like you proposed above with no output for MI.

What should we do with text output like "inst" and "at" below.

> > +	  ui_out_text (uiout, "\tinst ");

Would I split this to separate "inst" from the formatting?
Or is it OK to just say '_("\tinst ")'?


Thanks,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]