This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] string.h to gdb_string.h
- To: Kevin Buettner <kevinb at cygnus dot com>
- Subject: Re: [RFA] string.h to gdb_string.h
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Tue, 30 Jan 2001 10:19:40 -0800
- Cc: David Smith <dsmith at redhat dot com>, gdb-patches at sources dot redhat dot com
- References: <3A6F6E0F.81D7530D@redhat.com> <1010125005052.ZM1819@ocotillo.lan>
Kevin Buettner wrote:
> The only nit that I have with these changes is the use of the
> comma after 2001 in the copyright notices. The prevailing
> convention (if there is one) seems to be no comma after the
> final year. Also, it is my understanding that year ranges
> (e.g 1998-2000) are forbidden and that the years should be
> spelled out explicitly. (You got this part right, but it
> sure is tempting to use ranges.)
I wouldn't be so worried. The TODO file already mentions that we need
to clean up the copyright notices. We've even got patches to do this
pending.
> The ChangeLog entries probably ought to indicate the fact that
> you updated the copyright notice in these files too.
Um, some people do, some people don't. I'd be giving David credit for
even remembering to update that copyright year.
David, the changes are fine. Just watch out when you re-indent after
appending that extra year. I'll follow up with an account.
Andrew