Re: [RFA] string.h to gdb_string.h

[Kevin Buettner <kevinb at cygnus dot com>]

On Jan 24,  6:06pm, David Smith wrote:

> Here's a minor cleanup patch to change 6 occurrences of <string.h> to
> "gdb_string.h".  There were no changes in a test suite run after
> applying this patch (under Red Hat Linux 7.0).  (There are a few other
> files that use <string.h> instead of "gdb_string.h", but since these
> files don't get compiled under a native Linux build, I didn't feel
> comfortable including a patch for them.)
> 
> 2001-01-24  David Smith  <dsmith@redhat.com>
> 
> 	* event-loop.c: Changed inclusion of string.h to gdb_string.h.
> 	* ser-pipe.c: Ditto.
> 	* mi/mi-cmds.c: Ditto.
> 	* mi/mi-console.c: Ditto.
> 	* mi/mi-getopt.c: Ditto.
> 	* mi/mi-parse.c: Ditto.
> 
> Index: gdb/event-loop.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/event-loop.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 event-loop.c
> --- gdb/event-loop.c	2000/12/15 01:01:46	1.9
> +++ gdb/event-loop.c	2001/01/24 23:43:19
> @@ -1,5 +1,5 @@
>  /* Event loop machinery for GDB, the GNU debugger.
> -   Copyright 1999 Free Software Foundation, Inc.
> +   Copyright 1999, 2001, Free Software Foundation, Inc.

The only nit that I have with these changes is the use of the
comma after 2001 in the copyright notices.  The prevailing
convention (if there is one) seems to be no comma after the
final year.  Also, it is my understanding that year ranges
(e.g 1998-2000) are forbidden and that the years should be
spelled out explicitly.  (You got this part right, but it
sure is tempting to use ranges.)

The ChangeLog entries probably ought to indicate the fact that
you updated the copyright notice in these files too.

Kevin