This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix or1k gcc-4.9 -m32 compilation error


On Mon, Jun 9, 2014 at 10:43 PM, Maciej W. Rozycki
<macro@codesourcery.com> wrote:
>
>  First, this is a generated file, your change will go away the next time
> the maintainer regenerates it.  Second, it's been discussed to death
> recently and a conclusion made this needs to be fixed in CGEN even rather
> than the template this file has been made from before it is regenerated.
>
>  I don't know what happened to the fix -- Stefan, any progress on that?
>

I presented two patches, one that adds the 'U' suffix to only the
related constants (as the patch in this thread does)
https://sourceware.org/ml/cgen/2014-q2/msg00008.html
and one that adds the 'U' suffix to all enum constants.
https://sourceware.org/ml/cgen/2014-q2/msg00017.html

However, Frank was still worried that the 'U' suffix would cause
problems and was inclined to use a cast to (int) prefix instead.
https://sourceware.org/ml/cgen/2014-q2/msg00018.html

Changing the patch to do a cast to (int) isn't as straight forward as
it seems and I haven't got around to do that.

Stefan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]