This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/3] add testcases for function definitions
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: =?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= <zhouwj-fnst at cn dot fujitsu dot com>
- Cc: Josh Stone <jistone at redhat dot com>, <systemtap at sourceware dot org>, David Smith <dsmith at redhat dot com>
- Date: Wed, 11 Nov 2015 09:03:14 -0500
- Subject: Re: [PATCH 1/3] add testcases for function definitions
- Authentication-results: sourceware.org; auth=none
- References: <1447059456-19811-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com> <5640E0EE dot 2060803 at redhat dot com> <56415207 dot 6050905 at cn dot fujitsu dot com> <56415718 dot 2010100 at redhat dot com> <56415B6E dot 8030808 at cn dot fujitsu dot com> <56419783 dot 8050005 at cn dot fujitsu dot com> <56422AB0 dot 1060200 at redhat dot com> <5642DEAA dot 20205 at cn dot fujitsu dot com>
=?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= <zhouwj-fnst@cn.fujitsu.com> writes:
> [...]
> In case "div0", the probe will be exit with error.
> So the expected "EOF" will never be got.
(A "probe error { }" catches even those.)
> [...] And there are a lot of such problems. I don't think
> probe-final-"EOF" is needed, for it won't help much, though each
> error it introduces can be fixed easily.
Yeah.
I think the more basic problem is the general pattern of these test
cases, where multiple identical messages are printed to report subtest
status. In a more ideal world, instead of:
systemtap starting probe
systemtap ending probe
systemtap test success
systemtap test success
systemtap test success
systemtap test success
those .stp scripts that can self-diagnose should say simply:
success
or
failure (detail)
those .stp scripts that cannot self-diagnose should say simply:
result1 FOO
result2 BAR
result3 ZOO
No "systemtap" / "starting" / "ending" boilerplate is needed; nor
repeated lines whose counting is critical.
- FChE