This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/3] add testcases for function definitions
- From: Josh Stone <jistone at redhat dot com>
- To: Zhou, Wenjian/åæå <zhouwj-fnst at cn dot fujitsu dot com>
- Cc: systemtap at sourceware dot org, David Smith <dsmith at redhat dot com>
- Date: Tue, 10 Nov 2015 09:34:40 -0800
- Subject: Re: [PATCH 1/3] add testcases for function definitions
- Authentication-results: sourceware.org; auth=none
- References: <1447059456-19811-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com> <5640E0EE dot 2060803 at redhat dot com> <56415207 dot 6050905 at cn dot fujitsu dot com> <56415718 dot 2010100 at redhat dot com> <56415B6E dot 8030808 at cn dot fujitsu dot com> <56419783 dot 8050005 at cn dot fujitsu dot com>
On 11/09/2015 11:06 PM, "Zhou, Wenjian/åæå" wrote:
> On 11/10/2015 10:50 AM, "Zhou, Wenjian/åæå" wrote:
>> On 11/10/2015 10:31 AM, Josh Stone wrote:
>>> On 11/09/2015 06:10 PM, "Zhou, Wenjian/åæå" wrote:
>>>> To make sure nothing comes, we have to modify all cases which use the
>>>> stap_run. I don't think it's a good idea that modifying the cases which
>>>> are working well.
>>>
>>> If my probe-final-"EOF" idea works, then we can implement that entirely
>>> in stap_run, without modifying any testcases.
>>>
>>
>> Eh, if it works, I think the "{5}" won't be needed.
>> But I doubt whether it will introduce errors to some cases.
>> I will think more about it.
>>
>
> It works, but also has some side effects.
> It is better not to affect the cases which are working well, I think.
What are those side effects?