This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH v1 1/3] Reflect commits: 1. 8d98f95 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=8d98f956cc398d086794e19051c3380d599022da) 2. 5c9403e (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=5c9403eaf40951f8a4f55ed65f661b485ff44be7)
- From: Alexander Fedotov <alfedotov at gmail dot com>
- To: Eric Blake <eblake at redhat dot com>
- Cc: Richard dot Earnshaw at arm dot com, newlib at sourceware dot org
- Date: Wed, 31 Jul 2019 20:15:12 +0300
- Subject: Re: [PATCH v1 1/3] Reflect commits: 1. 8d98f95 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=8d98f956cc398d086794e19051c3380d599022da) 2. 5c9403e (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=5c9403eaf40951f8a4f55ed65f661b485ff44be7)
- References: <20190731163805.28834-1-alfedotov@gmail.com> <e5061ff4-f813-e52c-52df-6542d6b16a3a@redhat.com>
Yes, I just noticed that git send result isn't I've expected.
Will resend.
On Wed, 31 Jul 2019 at 20:13, Eric Blake <eblake@redhat.com> wrote:
> On 7/31/19 11:38 AM, Alexander Fedotov wrote:
>
> Way too long for the subject line (which should ideally be less than 70
> characters, and should be a one-line summary of what is changing), and
> missing a commit message body (that's where you can go into the details,
> including why the change is worthwhile, rather than just pointing to a
> URL).
>
>
> > ---
> > libgloss/arm/syscalls.c | 12 ++++++------
> > newlib/libc/sys/arm/crt0.S | 7 +++++++
> > newlib/libc/sys/arm/syscalls.c | 9 +++++++--
> > 3 files changed, 20 insertions(+), 8 deletions(-)
>
> I should know what the patch is intended to do by the time I get to this
> point in the email, but "Reflect commits" with two URLs as an
> overly-long subject has failed to do that. Can you please resubmit with
> a better commit message?
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
>