This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 7/31/19 11:38 AM, Alexander Fedotov wrote: Way too long for the subject line (which should ideally be less than 70 characters, and should be a one-line summary of what is changing), and missing a commit message body (that's where you can go into the details, including why the change is worthwhile, rather than just pointing to a URL). > --- > libgloss/arm/syscalls.c | 12 ++++++------ > newlib/libc/sys/arm/crt0.S | 7 +++++++ > newlib/libc/sys/arm/syscalls.c | 9 +++++++-- > 3 files changed, 20 insertions(+), 8 deletions(-) I should know what the patch is intended to do by the time I get to this point in the email, but "Reflect commits" with two URLs as an overly-long subject has failed to do that. Can you please resubmit with a better commit message? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |