This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH 2/2] RISC-V: Add _LITE_EXIT in crt0.S.
- From: Kito Cheng <kito dot cheng at gmail dot com>
- To: Jim Wilson <jimw at sifive dot com>
- Cc: ilia dot diachkov at optimitech dot com, Newlib <newlib at sourceware dot org>
- Date: Tue, 21 May 2019 11:23:21 +0800
- Subject: Re: [PATCH 2/2] RISC-V: Add _LITE_EXIT in crt0.S.
- References: <a60d2bd52d80df4aebac5ddb2ec5969b@optimitech.com> <CAFyWVabXpxKEZDrnkxiGfzWuBCz6E45ydAYhpoqxx=K4LuC34A@mail.gmail.com>
Hi Illa:
This patch LGTM :)
Hi Jim:
Seems like it's time to bump newlib in riscv/riscv-gnu-toolchain, I'll
do that after this 2 patches apply :)
On Tue, May 21, 2019 at 5:12 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Fri, May 17, 2019 at 4:53 PM <ilia.diachkov@optimitech.com> wrote:
> > This patch adds _LITE_EXIT in crt0.S to enable "lite exit" technique in
> > RISC-V. The changes have been tested in riscv/riscv-gnu-toolchain by
> > riscv-dejagnu with riscv-sim.exp/riscv-sim-nano.exp.
>
> Same comments as first part of the patch set.
>
> Personally, I'd put the .Lweak_atexit label inside _LITE_EXT ifdefs,
> but this matches the way that the ARM port does it, so should be OK
> also.
>
> To be fully effective, this requires build script changes to the
> github riscv/riscv-gnu-toolchain project, which will be handled as a
> separate patch.
>
> Jim