This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Improve performance of strstr

From: Eric Blake <eblake at redhat dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "newlib at sourceware dot org" <newlib at sourceware dot org>
Cc: nd <nd at arm dot com>
Date: Wed, 3 Oct 2018 09:09:55 -0500
Subject: Re: [PATCH v2] Improve performance of strstr
References: <DB5PR08MB1030A71D43420BDD16C060D183E90@DB5PR08MB1030.eurprd08.prod.outlook.com>

On 10/3/18 8:27 AM, Wilco Dijkstra wrote:

v2: Add documentation comment back in. Reduce size of shift table further to
gain another 10% performance on short strings.

I haven't reviewed the patch itself (although in theory it sounds fine),however:


Tested against GLIBC testsuite and passes randomized tests.

Passing the glibc testsuite isn't all that reassuring, as they justbarely had to squash a strstr bug this year that was not caught by theirtestsuite at the time:


https://sourceware.org/bugzilla/show_bug.cgi?id=23637

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Follow-Ups:
- Re: [PATCH v2] Improve performance of strstr
  - From: Wilco Dijkstra

References:
- [PATCH v2] Improve performance of strstr
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]