Re: [PATCH v2 14/17] ansification: remove _EXFUN, _EXFUN_NOTHROW

[Yaakov Selkowitz <yselkowitz at cygwin dot com>]

On 2017-12-07 12:55, Craig Howland wrote:
> On 12/07/2017 01:19 PM, Yaakov Selkowitz wrote:
>> diff --git a/newlib/libc/include/_ansi.h b/newlib/libc/include/_ansi.h
>> index 3e2490088..e2737ed48 100644
>> --- a/newlib/libc/include/_ansi.h
>> +++ b/newlib/libc/include/_ansi.h
>> @@ -47,19 +47,10 @@
>>   #endif
>>     #ifdef _HAVE_STDC
>> -#ifdef __CYGWIN__
>> -#define    _EXFUN_NOTHROW(name, proto)    __cdecl name proto _NOTHROW
>> -#define    _EXFUN(name, proto)        __cdecl name proto
>> -#else
>> -#define    _EXFUN_NOTHROW(name, proto)    name proto _NOTHROW
>> -#define    _EXFUN(name, proto)        name proto
>> -#endif
> For patches 13 and 14, the replacements for _EXFUN_NOTHROW(), _EXFUN(),
> _EXPARM(), and _EXFNPTR() are all dropping the __cdecl which is applied
> when __CYGWIN__ is defined.  I would expect this would wreak havoc for
> Cygwin, and will need to be addressed, somehow.

cdecl has been the default on Cygwin for as long as I remember; we think
this dates back to a time when perhaps that wasn't the case.

-- 
Yaakov

Attachment: signature.asc
Description: OpenPGP digital signature