This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 14/17] ansification: remove _EXFUN, _EXFUN_NOTHROW

From: Craig Howland <howland at LGSInnovations dot com>
To: <newlib at sourceware dot org>
Date: Thu, 7 Dec 2017 13:55:35 -0500
Subject: Re: [PATCH v2 14/17] ansification: remove _EXFUN, _EXFUN_NOTHROW
Authentication-results: sourceware.org; auth=none
References: <20171207181909.1112-1-yselkowi@redhat.com> <20171207181909.1112-15-yselkowi@redhat.com>

On 12/07/2017 01:19 PM, Yaakov Selkowitz wrote:

diff --git a/newlib/libc/include/_ansi.h b/newlib/libc/include/_ansi.h
index 3e2490088..e2737ed48 100644
--- a/newlib/libc/include/_ansi.h
+++ b/newlib/libc/include/_ansi.h
@@ -47,19 +47,10 @@
  #endif

#ifdef _HAVE_STDC

-#ifdef __CYGWIN__
-#define	_EXFUN_NOTHROW(name, proto)	__cdecl name proto _NOTHROW
-#define	_EXFUN(name, proto)		__cdecl name proto
-#else
-#define	_EXFUN_NOTHROW(name, proto)	name proto _NOTHROW
-#define	_EXFUN(name, proto)		name proto
-#endif

For patches 13 and 14, the replacements for _EXFUN_NOTHROW(), _EXFUN(),_EXPARM(), and _EXFNPTR() are all dropping the __cdecl which is applied when__CYGWIN__ is defined. I would expect this would wreak havoc for Cygwin, andwill need to be addressed, somehow.

Craig

Follow-Ups:
- Re: [PATCH v2 14/17] ansification: remove _EXFUN, _EXFUN_NOTHROW
  - From: Yaakov Selkowitz

References:
- [PATCH v2 00/17] Newlib ANSI-fication
  - From: Yaakov Selkowitz
- [PATCH v2 14/17] ansification: remove _EXFUN, _EXFUN_NOTHROW
  - From: Yaakov Selkowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]