Re: [PATCH v2 2/2] newlib/.../getreent.c: Allow to be provided by host and do so for RTEMS

[Joel Sherrill <Joel dot Sherrill at OARcorp dot com>]

Sorry to top post but replying from my phone on a plane.

Some of our tests are managing to get duplicate symbol errors when linking.

I put the dummy symbol in to follow the pattern in the file I patterned this after. I would have to look at the source again to see what file that was


On Oct 11, 2017, 9:49 AM, at 9:49 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
Hi Joel,

On Oct 11 07:57, Joel Sherrill wrote:
 RTEMS provides the option to have a global or per-thread reentrancy
 as part of application configuration. As part of this, RTEMS provides
 the implementation of __getreent() as appropriate. Allow the target
 to determine if this method is present in libc.a.
 ---
  newlib/configure.host<http://configure.host>        | 2 +-
  newlib/libc/reent/getreent.c | 8 ++++++++
  2 files changed, 9 insertions(+), 1 deletion(-)

 diff --git a/newlib/configure.host<http://configure.host> b/newlib/configure.host<http://configure.host>
 index fb3362b..7f397dd 100644
 --- a/newlib/configure.host<http://configure.host>
 +++ b/newlib/configure.host<http://configure.host>
 @@ -605,7 +605,7 @@ case "${host}" in
        default_newlib_io_long_long="yes"
        default_newlib_io_c99_formats="yes"
        newlib_cflags="${newlib_cflags} -D_COMPILING_NEWLIB"
 -      newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED
-DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED
-DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
 +newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED
-DEXIT_PROVIDED -DSIGNAL_PROVIDED -DGETREENT_PROVIDED
-DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE
-DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
          # turn off unsupported items in posix directory
        newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT
-D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN
-D_NO_POSIX_SPAWN"
        ;;
 diff --git a/newlib/libc/reent/getreent.c
b/newlib/libc/reent/getreent.c
 index 60ae6fb..124abce 100644
 --- a/newlib/libc/reent/getreent.c
 +++ b/newlib/libc/reent/getreent.c
 @@ -1,5 +1,11 @@
  /* default reentrant pointer when multithread enabled */

 +#ifdef GETREENT_PROVIDED
 +
 +int _dummy_getreent;
 +

So, why do you need this?  If you implement your own __getreent,
there's
no reason for this _dummy_getreent to exist, no?

Btw., Cygwin implements its own __getreent(), too, without having to
change newlib/libc/reent/getreent.c at all...


Corinna

--
Corinna Vinschen
Cygwin Maintainer
Red Hat