This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Long double complex methods




On 6/29/2017 1:39 AM, Corinna Vinschen wrote:
Hi Aditya,

On Jun 29 02:04, Aditya Upadhyay wrote:
Hello Developers,

I have ported all long double complex methods with suffix "l" from
NetBSD. I am attaching the patches for all the methods. I am
requesting you to please review these patches and point me any
modification needed.

Thanks & Regards,
[...]

Looks good, just the last patch in the series:

Subject: [PATCH 18/18] Importing csinl.c from NetBSD.

is missing the Makefile.am change.  Care to resend a v2 of patch 18?

Aditya may not need this but it won't hurt to post a hint. git
format-patch has some interesting options. The "-v N" option
adds a version number to the subject so it is clear on mailing
lists which patches are v1 and which are subsequent versions.
Something like this:

git format-patch -o DIRECTORY -v N MY_BRANCH master

I always dump the patches into a subdirectory since the names
are so long they tend to clutter up a normal source directory.

Also it makes it easier to use git send-email to send a patch
set to a mailing list.


Thanks,
Corinna


--joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]