Re: [PATCH 001/114] Add initial port for Phoenix-RTOS.

[Jakub Sejdak <jakub dot sejdak at phoesys dot com>]

Hi Sebastian,

Ad 1) I actually copied this license header from some other existing
file and changed first line to include our URL.
Feel free to edit it so it could fit newlib licensing. But it still
would be nice to have this URL somewhere.

Ad 2) The idea behind copying some of the standard headers was to
avoid duplicating some definitions in newlib and in our kernel.
So for example struct tm is defined directly in kernel header and
included in <time.h> by <phoenix/time.h>.

I am aware, that "duplication" of standard structures in libc and
kernel is a general approach, but we thought that one definition would
work best for us, since we are in very active development of
Phoenix-RTOS.
Would that be a big problem? I'm open for discussion.

Ad 3) Common network headers sounds like a good plan. I don't remember
adding any huge changes to those files. They are pretty much just
copies from Linux port.

2016-04-12 11:04 GMT+02:00 Sebastian Huber <sebastian.huber@embedded-brains.de>:
> Hello Jakub,
>
> I would add a new port as one big patch. Several files contain this license
> header:
>
> +/* Copyright (C) 2012-2016 Phoenix Systems (http://www.phoesys.com/).
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, write to the Free
> +   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> +   02111-1307 USA.  */
>
> Newlib is supposed to use a non-copyleft license, e.g. 2-clause BSD.
>
> You add duplicates of several standard header files to your port. Why do you
> not use the header files already present in Newlib?
>
> We work currently on an integration of the FreeBSD network header files
> defined by POSIX (and maybe some de-facto standard headers) for RTEMS. Maybe
> we should think about adding these header to default Newlib and share them
> between Cygwin, RTEMS and your new port.
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber@embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.
>