This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix "/*" within comment warning


On Mar 21 10:09, Yaakov Selkowitz wrote:
> On 2016-03-21 09:50, Corinna Vinschen wrote:
> >On Mar 21 09:11, Yaakov Selkowitz wrote:
> >>On 2016-03-21 06:44, Corinna Vinschen wrote:
> >>>>+/* These types are required by netinet/ *.h on Cygwin */
> >>>>  #if __BSD_VISIBLE || defined(__CYGWIN__)
> >>>>  #ifndef _BSDTYPES_DEFINED
> >>>>  /* also defined in mingw/gmon.h and in w32api/winsock[2].h */
> >>>
> >>>Apart from the comment patch, do we really need "|| defined(__CYGWIN__)"
> >>>here?
> >>
> >>The comment explains the very reason why those types are always needed.
> >
> >The comment doesn't really explain it.  Why is it needed for Cygwin
> >if it's not needed for glibc?
> 
> Because our netinet headers are from BSD and use BSD types.

Glibc's headers do as well.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]