This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix "/*" within comment warning


On 2016-03-21 06:44, Corinna Vinschen wrote:
+/* These types are required by netinet/ *.h on Cygwin */
  #if __BSD_VISIBLE || defined(__CYGWIN__)
  #ifndef _BSDTYPES_DEFINED
  /* also defined in mingw/gmon.h and in w32api/winsock[2].h */

Apart from the comment patch, do we really need "|| defined(__CYGWIN__)"
here?

The comment explains the very reason why those types are always needed.

--
Yaakov Selkowitz
Associate Software Engineer, ARM
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]