This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] [RTEMS] Add <sys/lock.h>
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: Chris Johns <chrisj at rtems dot org>
- Cc: Joel Sherrill <joel dot sherrill at oarcorp dot com>, newlib at sourceware dot org, devel at rtems dot org
- Date: Tue, 28 Jul 2015 08:39:57 +0200
- Subject: Re: [PATCH] [RTEMS] Add <sys/lock.h>
- Authentication-results: sourceware.org; auth=none
----- Chris Johns <chrisj@rtems.org> schrieb:
On 28/07/2015 5:51 am, Joel Sherrill wrote:
> This file is RTEMS specific and I am OK with it.
Do we have tests in RTEMS for this new API ?
This is a new API to RTEMS even if it is viewed as "internal" and the
RTEMS project should treat it like any other of the APIs it supports, ie
tests and documentation.
This is fully tested in test sptests/spsyslock01, see for example:
https://lists.rtems.org/pipermail/devel/2015-July/012004.html
In terms of documentation, where would you add it? Most functions are
pretty self explanatory (e.g. _Semaphore_Post(), _Mutex_Acquire(), etc.)
and do what they are expected to do usually. All of them have a simple
implementation.
>
> Sebastian is about to go on holiday so it would be appreciated
> to get this approved before he leaves.
>
> OK to commit?
>
Should we resolve the testing and documentation first ?
Since testing and documentation will be contained in RTEMS I would
really appreciate if we can commit this Newlib patch first since RTEMS
and GCC patches depend on it.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.