This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Prevent use of uninitialized file lock
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: newlib at sourceware dot org
- Date: Wed, 01 Jul 2015 14:52:43 +0200
- Subject: Re: [PATCH] Prevent use of uninitialized file lock
- Authentication-results: sourceware.org; auth=none
- References: <1435735590-4936-1-git-send-email-sebastian dot huber at embedded-brains dot de> <20150701123349 dot GL2918 at calimero dot vinschen dot de>
On 01/07/15 14:33, Corinna Vinschen wrote:
Hi Sebastian,
On Jul 1 09:26, Sebastian Huber wrote:
I am not sure if CHECK_INIT() is doing the right thing in case
_REENT_SMALL is defined.
The call to _REENT_SMALL_CHECK_INIT will still be required, afaics. The
problem is that only the call to __sinit initializes the std{in,out,err}
pointers so, without _REENT_SMALL_CHECK_INIT, fp will point into never
never land.
Ok, I will send a second version.
Btw., don't we have the same problem in libc/stdio/gets.c as well?
Probably yes. It seems a _REENT_SMALL_CHECK_INIT (ptr) is missing as
well? I try to add this to the second version.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.