Re: [PATCH v2] Add <sys/_stdint.h> for FreeBSD compatibility

[Corinna Vinschen <vinschen at redhat dot com>]

On Apr 28 17:27, Craig Howland wrote:
> On 04/28/2015 07:09 AM, Corinna Vinschen wrote:
> >Below is my proposal.
> >
> >It moves the _UINTPTR_EQ_ULONG stuff from sys/config.h to sys/_intsup.h
> >and renames it slightly to refer to the signed base type ("drop the
> >"U"s).  Then it adds a test to set _INT32_EQ_LONG using the same
> >technique.
> >
> >stdint.h and inttypes.h replace the test for __have_long32 with a test
> >for `ifdef _INT32_EQ_LONG'.
> >
> >Does that look ok?
>      A small suggestion:  rather than _INT32_EQ_LONG (int32 equals long),
> how about _INT32_IS_LONG or _INT32_TYPEIS_LONG, etc.?  They can be equal
> without being the same type,

But that was the idea of the patch.  It checks if __int32_t is defined
as long or int.  So if _INT32_EQ_LONG is defined, __int32_t equals long
and the expression _INT32_EQ_LONG is really correct in this case.

>      The grand plan looks OK.

Thanks.  I applied the patch.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpdF3OUr8eaJ.pgp
Description: PGP signature