Re: Wrong documentation for open()

[Eric Blake <eblake at redhat dot com>]

On 04/09/2015 10:36 AM, Friedrich Lobenstock wrote:
> Hello Eric!
> 
> Eric Blake wrote on 2015-04-09 17:38 MET:
>> > Patches welcome.
> Untested patch attached.
> 
> PS: I'm using the newlib contained in TI MSP430-GCC v3.2.3.0:
> gcc version 4.9.1 20140707 (prerelease (msp430-14r1-167)) (GNUPro 14r1)
> (Based on: GCC 4.8 GDB 7.7 Binutils 2.24 Newlib 2.1) (GCC)
> 
> -- MfG / Regards Friedrich Lobenstock
> 

The first hunks make sense...

>  
>  @example
>  int _open_r(void *@var{reent},
> -    const char *@var{file}, int @var{flags}, int @var{mode});
> +    const char *@var{file}, int @var{flags}, ...);

but this does not.  _open_r is not standardized, so we might as well
avoid ... and var-args, and just always pass four arguments when calling
it from within newlib.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature