Re: wcstold implementation

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Craig,

On Jan 22 19:04, Corinna Vinschen wrote:
> On Jan 22 12:44, Craig Howland wrote:
> > I actually have a _strtold_r() function that I did back in 2009 but never
> > quite got to the last step of submitting.  I had gotten an updated version
> > of ldtoa.c (the present one in Newlib is not David Gay's latest), and made a
> > wrapper for it.
> 
> This is cool.
> 
> > One thing that I did is that the function call for _strtold_r() has an
> > additional argument over strtold() to allow it to be called from scanf.  The
> > former wants errno set but the latter does not.
> > 
> > It does not, however, have the locale thing, as that was added after I had done it.
> > 
> > I have attached it for discussion and as a possible starting point. The
> > exact method by which error or not errno is handled is a question.  As
> > noted, I had put it into the _strtold_r() call, rather than having yet
> > another wrapper level.  The reasoning is that you already need to add the
> > reentry pointer, so another argument different from the standard call is not
> > necessarily a bad thing.
> 
> Hmm.  I'm wondering if that's feasible.  There's a certain expectation
> that the _r functions follow the non-_r functions with just the extra
> struct reent param, isn't it?  Wouldn't a wrapper be better, in fact?
> 
> > The list mailer bounced with all 3 files, so here are 2, the other
> > will follow.
> 
> Thanks.  I'm not overly fluent in floating point math coding, so, to
> me, if it's working it's fine :)
> 
> Well, the locale decimal_point handling should be added, but apart from
> the wrapper thingy above, that's all about it from my POV.
> 
> Feel free to send this eventually as a real patch submission.

Any news?  I'm really looking forward to get this new functionality.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgp28pgiE1a8v.pgp
Description: PGP signature