Re: Warning Building Newlib Head

[Corinna Vinschen <vinschen at redhat dot com>]

On Jan 14 10:23, Joel Sherrill wrote:
> 
> On 1/14/2015 10:12 AM, Corinna Vinschen wrote:
> > Hi Joel,
> >
> > On Jan 14 09:56, Joel Sherrill wrote:
> >> Hi
> >>
> >> Looking at the warnings in the build logs, I saw this:
> >>
> >> newlib/libc/posix/glob.c:383:7: warning: implicit declaration of
> >> function 'issetugid' [-Wimplicit-function-declaration]
> >>
> >> I was going to add an include to eliminate this but don't see one. The
> >> method
> >> is referenced in these files:
> >>
> >> $ grep -r issetugid .
> >> ./posix/glob.c:            issetugid() != 0 ||
> >> ./sys/rtems/crt0.c:RTEMS_STUB(int, issetugid (void), { return 0; })
> >> ./sys/linux/net/issetugid-stub.c:issetugid(void)
> >>
> >> Where should this method be prototyped?
> > Per the BSDs, in unistd.h, ideally with an #if __BSD_VISIBLE.
> >
> > OTOH, none of our targets actually provides this function, so it
> > might be better to add the prototype to glob.c itself?
> >
> RTEMS actually has this but the source is in our "libcsupport/"
> directory.  :)
> 
> Does that make Craig's suggestion to add it to unistd.h with __BSD_VISIBLE
> seem OK?

Didn't I say the same above? ;)

Sure, go ahead.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpbjCUa0JwRK.pgp
Description: PGP signature