Re: [PATCH 20/20] unlocked stdio extensions

[Corinna Vinschen <vinschen at redhat dot com>]

On Dec 17 15:23, Yaakov Selkowitz wrote:
> On 2014-12-17 15:17, Corinna Vinschen wrote:
> >Looks good, but there's one problem left:
> 
> Revised patch attached.

Thanks.  I'm seeing a problem with missing declarations:

  libc/stdio/getwc_u.c: In function âgetwc_unlockedâ:
  libc/stdio/getwc_u.c:51:3: error: implicit declaration of function
  âfgetwc_unlockedâ [-Werror=implicit-function-declaration]

  libc/stdio/getwchar_u.c: In function âgetwchar_unlockedâ:
  libc/stdio/getwchar_u.c:49:3: error: implicit declaration of function
  âfgetwc_unlockedâ [-Werror=implicit-function-declaration]

  libc/stdio/putwc_u.c: In function âputwc_unlockedâ:
  libc/stdio/putwc_u.c:52:3: error: implicit declaration of function
  âfputwc_unlockedâ [-Werror=implicit-function-declaration]

  libc/stdio/putwchar_u.c: In function âputwchar_unlockedâ:
  libc/stdio/putwchar_u.c:51:3: error: implicit declaration of function
  âfputwc_unlockedâ [-Werror=implicit-function-declaration]

The files should #define _GNU_SOURCE beforet he #include block to get
the matching prototypes from stdio.h.

Two bugs in the documentaion part, both of them missing bracketing:

fputws.c:

  PORTABILITY
  <<fputws> is required by C99 and POSIX.1-2001.
         ^^^

getwchar.c:

  The alternate functions <<_getwchar_r>> and <<_getwchar_unlocked_r> are
                                                                   ^^^

With these changes, ok to apply.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpQxcKA3xCpk.pgp
Description: PGP signature