This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix type signature of feof and ferror in c++

On Dec 11 10:23, Jonathan Roelofs wrote:
> On 12/11/14 10:04 AM, Corinna Vinschen wrote:
> >On Dec 11 09:08, Jonathan Roelofs wrote:
> >>This fixes one of the libc++ tests: depr/depr.c.headers/stdio_h.pass.cpp
> >
> >>diff --git a/ChangeLog b/ChangeLog
> >>index 5bea065..640bccf 100644
> >>--- a/ChangeLog
> >>+++ b/ChangeLog
> >>@@ -1,3 +1,7 @@
> >>+2014-12-11  Jonathan Roelofs  <...>
> >>+
> >>+	* libc/include/stdio.h: Fix type signature of feof and ferror in c++
> >>+
> >
> >Please don't send ChangeLogs as diffs, always plain.  They won't apply
> >cleanly most of the time.
> Ok, yeah I could see that being annoying. Didn't know there was an etiquette
> for that. Should I be putting them in the body of the email when I send a
> patch?

Sure, that's absolutely ok.

> >Wouldn't it make more sense for all targets to move this into the
> >definitions of __sfeof/__sferror?
> Depends on what the type signature of __sfeof and __sferror are supposed to
> be... that I don't know.  If those are just internal newlib things, then I
> don't think it really matters, either way would work.

Ok, patch applied then.


Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgp7jAUjtLefW.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]