This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Declare sethostname() if __BSD_VISIBLE is defined
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: newlib at sourceware dot org
- Date: Fri, 24 Oct 2014 11:45:25 +0200
- Subject: Re: [PATCH] Declare sethostname() if __BSD_VISIBLE is defined
- Authentication-results: sourceware.org; auth=none
- References: <1414137434-16394-1-git-send-email-sebastian dot huber at embedded-brains dot de> <20141024093951 dot GA1436 at calimero dot vinschen dot de>
On 24/10/14 11:39, Corinna Vinschen wrote:
On Oct 24 09:57, Sebastian Huber wrote:
>Prototype is according to glibc and not FreeBSD which uses int for the
>second parameter. I am not sure how to do the alternative feature test
>described in the Linux manpage.
Testing for defined(__BSD_VISIBLE) seems wrong to me. Per sys/cdefs.h
__BSD_VISIBLE is often define as 0. Taking the Linux man page into
account, shouldn't that be something like
#if __BSD_VISIBLE || (defined (_XOPEN_SOURCE) && __XSI_VISIBLE < 500)
?
Oh, yes, this defined(__BSD_VISIBLE) is nonsense. I send a new patch.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.