This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] define M_PI etc. if _XOPEN_SOURCE is defined appropriately

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 30 Jul 2014 16:19:06 +0200
Subject: Re: [PATCH] define M_PI etc. if _XOPEN_SOURCE is defined appropriately
Authentication-results: sourceware.org; auth=none
References: <53D8F928 dot 9070901 at dronecode dot org dot uk> <53D8FD50 dot 1020907 at dronecode dot org dot uk>
Reply-to: newlib at sourceware dot org

On Jul 30 15:12, Jon TURNEY wrote:
> On 30/07/2014 14:54, Jon TURNEY wrote:
> >math.h only defines M_PI and similar constants if __STRICT_ANSI__ is not
> >defined.
> >
> >SUSv2 specifies that math.h should define some of these constants [1].
> >
> >Attached is a patch to also define these constants if _XOPEN_SOURCE is
> >defined appropriately.
> 
> So bad :-(
> 
> This patch doesn't correctly handle the case where _XOPEN_SOURCE is defined
> as the empty string.  Amended patch attached.

You can workaround that by using the definition of __XSI_VISIBLE
from <sys/cdefs.h>.  It's always defined and non-empty.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpYxGRQpUerH.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] define M_PI etc. if _XOPEN_SOURCE is defined appropriately
  - From: Jon TURNEY

References:
- [PATCH] define M_PI etc. if _XOPEN_SOURCE is defined appropriately
  - From: Jon TURNEY
- Re: [PATCH] define M_PI etc. if _XOPEN_SOURCE is defined appropriately
  - From: Jon TURNEY

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]