This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add missing strerror() strings, clean up

Hi Cragi,

Thanks for taking the time!

Could you include me on any replies? I'm not subscribed.

> On 07/10/2014 06:26 AM, Nick Withers wrote:
>> Hi all,
>> The attached patch:
>> - Adds to strerror()'s strerror.c strings for:
>>    ...
>> - Changes the following comments in errno.h to match the implementation:
>>    ...
>>    - EDOM, from "Math arg out of domain of func" to "Math
>> argument" (would "Mathematics argument out of domain of function" or
>> "Mathematical (...)" be better?)
> "Math argument" would be a step backwards. If it were to be changed at
> all, use the POSIX "Mathematics argument out of domain of
> function." (The existing is POSIX with 3 abbreviations, and really
> could be left as-is.)

"Math argument" is the existing message. There's a comment in errno.h
though, that is meant to match the message proper, and currently does
not. That's what's addressed here.

However, if you'd like me to change it to "Mathematics argument out of
domain of function", happy to do so (I certainly like that better...).

>> ...
>> P.S.: Should EMFILE's "Too many open files" actually be "File descriptor
>> value too large"? ENFILE's for the former, I think? Perhaps they're one
>> and the same in Newlib :-)
> The description ought to match POSIX, so , yes, EMFILE ought to
> change. (It appears to only be used in 1 place
> (libc/machine/spu/stdio.c), where it is not entirely clear with a
> cursory examination whether it is being used properly or not.)

Righto, I'll send a PATCH-v2 when we've got the EDOM bit sorted.

In my previous message, I also missed that the patch adds ENETRESET,
"Connection aborted by network".

> Craig
Nick Withers

Embedded Systems Programmer
Department of Nuclear Physics, Research School of Physics and Engineering
The Australian National University (CRICOS: 00120C)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]