This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Request: WEAK declaration of _sbrk() for embedded
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Joey Ye <joey dot ye dot cc at gmail dot com>
- Cc: A dot Grieco at erhardt-leimer dot com, Newlib Mailing List <newlib at sourceware dot org>
- Date: Tue, 7 Jan 2014 13:00:39 +0000
- Subject: Re: Request: WEAK declaration of _sbrk() for embedded
- Authentication-results: sourceware.org; auth=none
- References: <OF2DE092BE dot E155D4DA-ONC1257C38 dot 004886B1-C1257C38 dot 0048E2C4 at erhardt-leimer dot com> <CAL0py24_QS56gV_ouBrtTZJQM-gx+3+Kpu_iuvQbtvH38uhrfg at mail dot gmail dot com> <CAL0py27QtGeoZ5wR=_Ri7qf5cJ=nD4HHS4H9SrX-+bVmShmEeg at mail dot gmail dot com>
On 7 January 2014 09:32, Joey Ye <joey.ye.cc@gmail.com> wrote:
> It is a sensible suggestion to me. The thing I'm not sure of is what
> else needed besides _sbrk.
>
> Anyone have any objection before I write a patch for _sbrk?
>
> Thanks,
> Joey
>
> On Tue, Jan 7, 2014 at 5:31 PM, Joey Ye <joey.ye.cc@gmail.com> wrote:
>> It is a sensible suggestion to me. The thing I'm not sure of is what
>> else needed besides _sbrk.
>>
>> Anyone have any objection before I write a patch for _sbrk?
>>
>> Thanks,
>> Joey
Joey, this change seems sensible to me, while you are looking at this
perhaps you could quickly review each of the other interface functions
exposed by syscalls.c (arm & aarch64) and deal with any other cases
where we are missing a weak attribute?
Cheers
/Marcus