This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Update newlib so that it passes libc++'s tests
- From: JF Bastien <jfb at chromium dot org>
- To: Jeff Johnston <jjohnstn at redhat dot com>
- Cc: Craig Howland <howland at lgsinnovations dot com>, "newlib at sourceware dot org" <newlib at sourceware dot org>
- Date: Fri, 20 Dec 2013 15:36:22 -0500
- Subject: Re: [PATCH] Update newlib so that it passes libc++'s tests
- Authentication-results: sourceware.org; auth=none
- References: <CABdywOcnSpU=r5NGDDzhea4gxALh8LRL4A9vRY31wFjLhtF5zA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1312170153500 dot 29265 at digraph dot polyomino dot org dot uk> <CABdywOdE5rkMLOyK3NrM+k+OrpRLkbjPp5oddqDz9vv5wKkd0A at mail dot gmail dot com> <52B220A8 dot 4010901 at LGSInnovations dot com> <CABdywOcPo-_RSjBiWeZNeMaB5Aih23OT7u3qXL896NfcqEu6bg at mail dot gmail dot com> <156240854 dot 42718969 dot 1387564988624 dot JavaMail dot root at redhat dot com> <52B498C3 dot 8000108 at LGSInnovations dot com> <CABdywOd7G0W2b2j1WZBZQDJbBk6z_xBpQXXhW4Gahp+Yasq8fQ at mail dot gmail dot com> <1293058429 dot 42755827 dot 1387571108869 dot JavaMail dot root at redhat dot com>
> As mentioned, if the libc++ test passes with an incremental fix, then I am fine
> with it. If it does not fix the libc++ test, then there is no impetus to get a
> partial fix in now and we can figure out a more correct solution.
>
> So, can you put together a patch that fixes the libc++ test, does not touch
> stdint.h and is incrementally better for wchar.h?
I'm currently traveling so testing things isn't as easy as it should be.
IIRC the relevant test is test/depr/depr.c.headers/stdint_h.pass.cpp:
// WCHAR_MIN
assert(WCHAR_MIN == std::numeric_limits<wchar_t>::min());
// WCHAR_MAX
assert(WCHAR_MAX == std::numeric_limits<wchar_t>::max());
Many other tests from libc++'s test suite will pass with an
incremental fix, so it could still be a viable option, but I think
this particular test won't pass.