This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Fix __signbitf() and __signbitd() for 16-bit targets

On Dec 18 08:52, Nick Clifton wrote:
> Hi Guys,
> 
>   I ran across a couple of bugs in the implementations of __signbitf()
>   and __signbitd() should the target happen to use 16-bit integers:
>   
>   Firstly the functions pass the "unsigned int" type to the
>   GET_FLOAT_WORD and GET_HIGH_WORD macros, but these macros are
>   expecting a "__uint32_t" type.
> 
>   Secondly they assume that the "int" return type is wide enough to hold
>   bit 31 of the extracted word.
> 
>   The patch below fixes both of these problems and results in fixed gcc
>   testcase (gcc.dg/pr43419.c) when run on a 16-bit target.  (With no
>   regressions for 32-bit and 64-bit targets).
> 
>   OK to apply ?

Yes, thank you.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpP6ojvoEHFV.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]