This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Patch RTEMS: make PAGESIZE and PAGE_SIZE match
- From: Gedare Bloom <gedare at rtems dot org>
- To: "newlib at sourceware dot org" <newlib at sourceware dot org>
- Date: Mon, 9 Dec 2013 09:42:41 -0500
- Subject: Re: Patch RTEMS: make PAGESIZE and PAGE_SIZE match
- Authentication-results: sourceware.org; auth=none
- References: <CAC82fA174HWMnLvZWwEjXP9RYRBADzWnDf1QKR1djAu1FAL_Yg at mail dot gmail dot com> <20131209105540 dot GA15875 at calimero dot vinschen dot de>
On Mon, Dec 9, 2013 at 5:55 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
> On Dec 5 10:55, Gedare Bloom wrote:
>> According to POSIX PAGESIZE and PAGE_SIZE must be identical. This
>> pages changes the constant PAGESIZE in
>> newlib/libc/sys/rtems/include/limits.h to match the PAGE_SIZE constant
>> defined in newlib/libc/sys/rtems/machine/param.h.
>>
>> See also: https://www.rtems.org/bugzilla/show_bug.cgi?id=1216
>>
>> 2013-12-05 Chirayu Desai <...>
>>
>> * newlib/libc/sys/rtems/include/limits.h: Update page size
>> to match newlib/libc/sys/rtems/machine/param.h
>
>> Index: newlib/libc/sys/rtems/include/limits.h
>> ===================================================================
>> RCS file: /cvs/src/src/newlib/libc/sys/rtems/include/limits.h,v
>> retrieving revision 1.5
>> diff -u -r1.5 limits.h
>> --- newlib/libc/sys/rtems/include/limits.h 15 Oct 2013 17:38:32 -0000 1.5
>> +++ newlib/libc/sys/rtems/include/limits.h 5 Dec 2013 15:39:34 -0000
>> @@ -66,7 +66,7 @@
>> #define DELAYTIMER_MAX 32
>> #define MQ_OPEN_MAX 8
>> #define MQ_PRIO_MAX 32
>> -#define PAGESIZE 1
>> +#define PAGESIZE (1<<12)
>
> Wouldn't
>
> #define PAGESIZE PAGE_SIZE
>
> make more sense here?
>
Is the macro PAGE_SIZE defined at this location? From what I can tell,
PAGESIZE and PAGE_SIZE can't depend on each other directly. I can't
try it out at the moment to test though.
-Gedare
>
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat