This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Do not break buffers in fvwrite for unbuffered files


On Oct 21 10:36, Federico wrote:
> -	  w = fp->_write (ptr, fp->_cookie, p, MIN (len, BUFSIZ));
> +	  w = fp->_write (ptr, fp->_cookie, p, len);

As noted in my other reply, len is size_t but the parameter to _write
may be int, even after my _READ_WRITE_BUFSIZE_TYPE patch has been applied.

Therefore the type size difference still has to be accounted for.
Maybe something like this is sufficient:

  w = fp->_write (ptr, fp->_cookie, p, MIN (len, MAX_INT));

???


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpdFwqHPXigL.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]