Re: [PATCH 1/7] New path defines for <paths.h>

[Corinna Vinschen <vinschen at redhat dot com>]

On Oct  8 14:45, Sebastian Huber wrote:
> newlib/ChangeLog
> 2013-10-08  Sebastian Huber <sebastian.huber@embedded-brains.de>
> 
> 	* libc/include/paths.h (_PATH_DEVNULL): Define.
> 	(_PATH_DEVZERO): Likewise.
> ---
>  newlib/libc/include/paths.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/newlib/libc/include/paths.h b/newlib/libc/include/paths.h
> index 36cf78a..b1c70f5 100644
> --- a/newlib/libc/include/paths.h
> +++ b/newlib/libc/include/paths.h
> @@ -2,6 +2,8 @@
>  #define _PATHS_H_
>  
>  #define _PATH_DEV	"/dev/"
> +#define _PATH_DEVNULL   "/dev/null"
> +#define _PATH_DEVZERO   "/dev/zero"

Why these two?  Why for all targets?  _PATH_DEV and _PATH_BSHELL are
used in newlib(*), but the additional definition of only _PATH_DEVNULL
and _PATH_DEVZERO looks a bit arbitrary.  What's the reason?

And, wouldn't it make sense to either keep paths.h as is and require
target-specific overrides, or, alternatively, add everything and the
kitchen sink to paths.h by providing the full BSD version of the file?

>  #define _PATH_BSHELL    "/bin/sh"
>  
>  #endif /* _PATHS_H_ */
> -- 
> 1.7.7

Corinna


(*) as is _PATH_PASSWD, but that's local to getpass.c for some,
    probably historical reason.
-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpWkf_ubLulR.pgp
Description: PGP signature