Re: [patch, mips] Fix parallel build on MIPS

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 03 September 2013 14:17:08 Steve Ellcey wrote:
> On Tue, 2013-09-03 at 10:52 -0700, Steve Ellcey wrote:
> > On Tue, 2013-09-03 at 13:37 -0400, Mike Frysinger wrote:
> > > > --- a/libgloss/mips/Makefile.in
> > > > +++ b/libgloss/mips/Makefile.in
> > > > 
> > > >  install:
> > > > +	mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
> > > >  	@for file in $(CRT0) $(PCRT0) $(BSP); do \
> > > 
> > > this does not work because "@for" is not a shell command.  the @ needs
> > > to move from the for to the mkdir.
> > 
> > Hm, I thought it would work because I see it in the mn10300 Makefile.in
> > file.  My own rebuild hasn't gotten to the point of install yet so we
> > will see what happens when it does.
> 
> OK, I think I understand now.  We can leave the '@' on the for
> if we don't put a '; \' at the end of the mkdir (because then
> they are separate shell commands).

right.  new patch LGTM.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.