Re: [patch, mips] Fix parallel build on MIPS

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 03 September 2013 12:58:20 Steve Ellcey wrote:
> On Sun, 2013-09-01 at 15:05 -0400, Mike Frysinger wrote:
> > On Friday 30 August 2013 11:04:02 Steve Ellcey wrote:
> > > --- a/libgloss/mips/Makefile.in
> > > +++ b/libgloss/mips/Makefile.in
> > > 
> > >  install:
> > >  	@for file in $(CRT0) $(PCRT0) $(BSP); do \
> > > -	  $(INSTALL_DATA) $${file} $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
> > > +	  mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
> > > +	  $(INSTALL_DATA) $${file}
> > > $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}/$${file}; \
> > 
> > shouldn't the mkdir be done outside of the for loop ?
> 
> I suppose so.  The targets I was copying (epiphany, libnosys) do it
> inside the loop too.  This doesn't cause any problems because of the
> '-p' option to mkdir which says to return no error if the directory
> already exists.  But there is no reason for it to be in the loop so
> here is a patch with the mkdir in front of the loop.

right ... those targets should get fixed :)

> --- a/libgloss/mips/Makefile.in
> +++ b/libgloss/mips/Makefile.in
> 
>  install:
> +	mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
>  	@for file in $(CRT0) $(PCRT0) $(BSP); do \

this does not work because "@for" is not a shell command.  the @ needs to move 
from the for to the mkdir.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.