Re: [PATCH 06/14] FreeBSD update of __strong_reference, etc.

[Sebastian Huber <sebastian dot huber at embedded-brains dot de>]

On 04/17/2013 05:19 PM, Craig Howland wrote:
> On 04/17/2013 09:16 AM, Sebastian Huber wrote:
> > newlib/ChangeLog
> > 2013-04-17  Sebastian Huber <sebastian.huber@embedded-brains.de>
> >
> >     * libc/include/sys/cdefs.h (__strong_reference): Use definition
> >     of latest FreeBSD source.
> Should the change log entry highlight that the __strong_reference change is
> such that the user will likely have to edit any code that uses it (given that a
> ; is removed)?  Perhaps something like "Potentially incompatible change, ;
> removed."?
[...]

I will update the ChangeLog accordingly if we remove the ';'.  It is also 
possible to keep the ';'.  The ';' was removed in FreeBSD in 2005:

commit 6a1d883879d0a43d5c1614ddea8a41b29f179fb1
Author: kbyanc <kbyanc@FreeBSD.org>
Date:   Thu Jul 14 19:30:49 2005 +0000

    Remove superfluous semicolon at the end of the __strong_reference() macro
    definition.

diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h
index d8499fe..fa5dc44 100644
--- a/sys/sys/cdefs.h
+++ b/sys/sys/cdefs.h
@@ -345,7 +345,7 @@
 #if defined(__GNUC__) || defined(__INTEL_COMPILER)
 #ifndef __INTEL_COMPILER
 #define        __strong_reference(sym,aliassym)        \
-       extern __typeof (sym) aliassym __attribute__ ((__alias__ (#sym)));
+       extern __typeof (sym) aliassym __attribute__ ((__alias__ (#sym)))
 #endif
 #ifdef __STDC__
 #define        __weak_reference(sym,alias)     \

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.