This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Final(?) patch to update libtool in GCC and src trees
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- Cc: Andreas Schwab <schwab at suse dot de>, bonzini at gnu dot org, Dave Korn <dave dot korn at artimi dot com>, 'Steve Ellcey' <sje at cup dot hp dot com>, binutils at sourceware dot org, gcc-patches at gcc dot gnu dot org, gdb-patches at gcc dot gnu dot org, newlib at sourceware dot org, aoliva at redhat dot com, libtool at cwilson dot fastmail dot fm
- Date: Wed, 11 Apr 2007 10:57:00 +0200
- Subject: Re: Final(?) patch to update libtool in GCC and src trees
- References: <006501c77bab$1753a410$2e08a8c0@CAM.ARTIMI.COM> <200704102006.NAA21177@hpsje.cup.hp.com> <008301c77bd6$7fa44bc0$2e08a8c0@CAM.ARTIMI.COM> <461C8FE6.9010800@lu.unisi.ch> <je7isj5mc9.fsf@sykes.suse.de> <461CA157.1020908@lu.unisi.ch>
* Paolo Bonzini wrote on Wed, Apr 11, 2007 at 10:50:31AM CEST:
>>> I would rewrite them at the very least as
>>>
>>> AC_PROG_AWK
>>> AC_PROG_CXX
>>>
>>> if test "${use_libtool}" = "yes"; then
>>> AC_LIBTOOL_WIN32_DLL
>>> AM_PROG_LIBTOOL
>>> fi
>> I think that should use AS_IF instead.
>
> Does AS_IF put required macros outside its expansion? That's a
> cool feature if it does.
Only with Autoconf 2.60 and newer.
> However, if this is the case, it is also a problem.
> AM_PROG_LIBTOOL used to expand its subparts via
> AC_REQUIRE, which would sort of undo the effect of
> the if statement.
Yes, I don't think it'll help here. But also I don't see why CXX should
come into play here at all, if not by an old 1.5.x libtool.m4 file that
is picked up by aclocal (without having tested anything, though).
Cheers,
Ralf