This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Final(?) patch to update libtool in GCC and src trees
- From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: bonzini at gnu dot org, Dave Korn <dave dot korn at artimi dot com>, 'Steve Ellcey' <sje at cup dot hp dot com>, binutils at sourceware dot org, gcc-patches at gcc dot gnu dot org, gdb-patches at gcc dot gnu dot org, newlib at sourceware dot org, Ralf dot Wildenhues at gmx dot de, aoliva at redhat dot com, libtool at cwilson dot fastmail dot fm
- Date: Wed, 11 Apr 2007 10:50:31 +0200
- Subject: Re: Final(?) patch to update libtool in GCC and src trees
- References: <006501c77bab$1753a410$2e08a8c0@CAM.ARTIMI.COM> <200704102006.NAA21177@hpsje.cup.hp.com> <008301c77bd6$7fa44bc0$2e08a8c0@CAM.ARTIMI.COM> <461C8FE6.9010800@lu.unisi.ch> <je7isj5mc9.fsf@sykes.suse.de>
- Reply-to: bonzini at gnu dot org
I would rewrite them at the very least as
AC_PROG_AWK
AC_PROG_CXX
if test "${use_libtool}" = "yes"; then
AC_LIBTOOL_WIN32_DLL
AM_PROG_LIBTOOL
fi
I think that should use AS_IF instead.
Does AS_IF put required macros outside its expansion? That's a
cool feature if it does.
However, if this is the case, it is also a problem.
AM_PROG_LIBTOOL used to expand its subparts via
AC_REQUIRE, which would sort of undo the effect of
the if statement.
Paolo