This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
[PATCH] fix msvcc.sh to not pass -safeseh to ml64
- From: Dan Witte <dwitte at mozilla dot com>
- To: libffi-discuss <libffi-discuss at sourceware dot org>
- Cc: neil at httl dot net
- Date: Tue, 3 Aug 2010 14:15:47 -0700 (PDT)
- Subject: [PATCH] fix msvcc.sh to not pass -safeseh to ml64
Anthony,
Attached is a patch to fix Win64 builds, since ml64 doesn't like -safeseh.
Cheers,
Dan.
diff --git a/ChangeLog b/ChangeLog
index 2547ad3..7ba744c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2010-08-03 Neil Rashbrooke <neil@httl.net>
+
+ * msvcc.sh: Don't pass -safeseh to ml64 because behavior is buggy.
+
2010-07-22 Dan Witte <dwitte@mozilla.com>
* src/*/ffitarget.h: Make FFI_LAST_ABI one past the last valid ABI.
diff --git a/msvcc.sh b/msvcc.sh
index 551c73d..c73cb15 100755
--- a/msvcc.sh
+++ b/msvcc.sh
@@ -46,6 +46,7 @@ args="-nologo"
md=-MD
cl="cl"
ml="ml"
+safeseh="-safeseh"
output=
while [ $# -gt 0 ]
@@ -63,6 +64,7 @@ do
-m64)
cl="cl" # "$MSVC/x86_amd64/cl"
ml="ml64" # "$MSVC/x86_amd64/ml64"
+ safeseh=
shift 1
;;
-O*)
@@ -164,7 +166,7 @@ if [ -n "$assembly" ]; then
echo "$cl -nologo -EP $includes $defines $src > $ppsrc"
"$cl" -nologo -EP $includes $defines $src > $ppsrc || exit $?
output="$(echo $output | sed 's%/F[dpa][^ ]*%%g')"
- args="-nologo -safeseh $single $output $ppsrc"
+ args="-nologo $safeseh $single $output $ppsrc"
echo "$ml $args"
eval "\"$ml\" $args"