Re: [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation

[Lukasz Majewski <lukma at denx dot de>]

Hi Andreas,

> On Feb 12 2020, Lukasz Majewski wrote:
> 
> > (And I do guess that this - auto include - is related to the
> > directory search patch in Makefiles?)  
> 
> For the same reason <time.h> finds include/time.h first during build.
> 
> Andreas.
> 

I've added the struct __timespec64 definition to
./include/bits/struct/timespec.h


and I had build errors on ./include/time.h which uses struct
__timespec64 massively.
It requires explicit adding of #include
<include/bits/struct/timespec.h> or <bits/struct/timespec.h>

The same #include was required in ./include/mqueue.h to have proper
struct __timespec64 declaration.

It seems like the glibc build system fails to #include it automatically
to internal headers (like ./include/time.h and ./include/mqueue.h).


IMHO, it would be better to add definition of struct __timespec64 into 
./include/bits/types/struct___timespec64.h (which is intended for
internal glibc use).

Such approach would follow what we do have now in ./include/time.h
with # include <bits/types/struct_timeval.h>


Or what I'm missing here?


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpSnrHg40uB2.pgp
Description: OpenPGP digital signature