Re: [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation

[Lukasz Majewski <lukma at denx dot de>]

Hi Andreas,

> On Feb 12 2020, Lukasz Majewski wrote:
> 
> > Just to clarify - the time.h here is from ./include glibc sources
> > directory, so it is "internal" for glibc.  
> 
> But it is a wrapper around <time.h>.

Yes, indeed - it includes <time/time.h>

> 
> > In other words - I would like to know if your comment was regarding
> > polluting the glibc internal namespace?  
> 
> It's not about polluting, but since the #include is conditional, we
> have inconsistent environment between configurations, which isn't
> nice.

Ach... I see.

> 
> By moving struct __timespec64 to <include/bits/struct/timespec.h> we
> can avoid that inconsistency.

Maybe <include/bits/types/struct___timespec64.h> would be a better
place/name?

In that way we would follow other "internal" structs definitions - i.e.
<include/bits/types/struct_timespec.h>

(which only has #include·<time/bits/types/struct_timespec.h>)

> 
> Andreas.
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpML4FktSurR.pgp
Description: OpenPGP digital signature