This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: V2 [PATCH 4/5] i386: Remove _exit.S
LGTM thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
On 08/01/2020 13:15, H.J. Lu wrote:
> The generic implementation is suffice since __NR_exit_group is always
> support and i386 does define ABORT_INSTRUCTION.
> ---
> sysdeps/unix/sysv/linux/i386/_exit.S | 44 ----------------------------
> 1 file changed, 44 deletions(-)
> delete mode 100644 sysdeps/unix/sysv/linux/i386/_exit.S
>
> diff --git a/sysdeps/unix/sysv/linux/i386/_exit.S b/sysdeps/unix/sysv/linux/i386/_exit.S
> deleted file mode 100644
> index 1f7bfeb7e7..0000000000
> --- a/sysdeps/unix/sysv/linux/i386/_exit.S
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -/* Copyright (C) 2002-2020 Free Software Foundation, Inc.
> - This file is part of the GNU C Library.
> -
> - The GNU C Library is free software; you can redistribute it and/or
> - modify it under the terms of the GNU Lesser General Public
> - License as published by the Free Software Foundation; either
> - version 2.1 of the License, or (at your option) any later version.
> -
> - The GNU C Library is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - Lesser General Public License for more details.
> -
> - You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library; if not, see
> - <https://www.gnu.org/licenses/>. */
> -
> -#include <sysdep.h>
> -
> - .text
> - .type _exit,@function
> - .global _exit
> -_exit:
> - movl 4(%esp), %ebx
> -
> - /* Try the new syscall first. */
> -#ifdef __NR_exit_group
> - movl $__NR_exit_group, %eax
> - ENTER_KERNEL
> -#endif
> -
> - /* Not available. Now the old one. */
> - movl $__NR_exit, %eax
> - /* Don't bother using ENTER_KERNEL here. If the exit_group
> - syscall is not available AT_SYSINFO isn't either. */
> - int $0x80
> -
> - /* This must not fail. Be sure we don't return. */
> - hlt
> - .size _exit,.-_exit
> -
> -libc_hidden_def (_exit)
> -rtld_hidden_def (_exit)
> -weak_alias (_exit, _Exit)
>