This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: V2 [PATCH 2/5] i386/sub_n.S: Add a missing _CET_ENDBR to indirect jump target

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: libc-alpha at sourceware dot org
Date: Thu, 9 Jan 2020 18:13:43 -0300
Subject: Re: V2 [PATCH 2/5] i386/sub_n.S: Add a missing _CET_ENDBR to indirect jump target
References: <20200108161535.6141-1-hjl.tools@gmail.com> <20200108161535.6141-3-hjl.tools@gmail.com>

LGTM thanks.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

On 08/01/2020 13:15, H.J. Lu wrote:
> diff --git a/sysdeps/i386/sub_n.S b/sysdeps/i386/sub_n.S
> index caac89177b..16ebd9169b 100644
> --- a/sysdeps/i386/sub_n.S
> +++ b/sysdeps/i386/sub_n.S
> @@ -91,6 +91,7 @@ L(oop):	movl	(%esi),%eax
>  	movl	8(%esi),%eax
>  	sbbl	8(%edx),%eax
>  	movl	%eax,8(%edi)
> +	_CET_ENDBR
>  	movl	12(%esi),%eax
>  	sbbl	12(%edx),%eax
>  	movl	%eax,12(%edi)

References:
- V2 [PATCH 0/5] i386: Finish CET support
  - From: H.J. Lu
- V2 [PATCH 2/5] i386/sub_n.S: Add a missing _CET_ENDBR to indirect jump target
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]