Re: [review v4] localedef: Add verbose messages for failure paths.

[Florian Weimer <fweimer at redhat dot com>]

* Carlos O'Donell:

> On 12/10/19 4:34 PM, DJ Delorie wrote:
>> "Carlos O'Donell (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>> writes:
>>> A locale/programs/xasprintf.c
>> 
>> We already have one in support/xasprintf.c.  We shouldn't have two
>> copies in the tree, somehow.
>
> This was discussed originally, and we can't or rather don't want to
> use the support/xasprintf.c since it may need to be built differently
> from what we need for a distributed binary.
>
> I would like to keep support/* infrastructure directly decoupled from
> the installed programs we build.
>
> Yes that means having possibly two xmalloc's and two xasprintf's.
>
> For example the runtime implementation needs gettext and translation
> for the error message, and calls error.
>
> The support implementation doesn't need translations and can include
> a bunch more headers and use FAIL_EXIT1.
>
> I would really like to consider them distinct implementation for
> distinct operating environments.

I agree.  It's not ideal, but there isn't that much commonality between
the implementations anyway.

Florian