This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [review v4] localedef: Add verbose messages for failure paths.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>, libc-alpha at sourceware dot org
- Date: Thu, 12 Dec 2019 13:15:46 -0500
- Subject: Re: [review v4] localedef: Add verbose messages for failure paths.
- References: <xn8snjuaph.fsf@greed.delorie.com>
On 12/10/19 4:34 PM, DJ Delorie wrote:
> "Carlos O'Donell (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> writes:
>> A locale/programs/xasprintf.c
>
> We already have one in support/xasprintf.c. We shouldn't have two
> copies in the tree, somehow.
This was discussed originally, and we can't or rather don't want to
use the support/xasprintf.c since it may need to be built differently
from what we need for a distributed binary.
I would like to keep support/* infrastructure directly decoupled from
the installed programs we build.
Yes that means having possibly two xmalloc's and two xasprintf's.
For example the runtime implementation needs gettext and translation
for the error message, and calls error.
The support implementation doesn't need translations and can include
a bunch more headers and use FAIL_EXIT1.
I would really like to consider them distinct implementation for
distinct operating environments.
--
Cheers,
Carlos.