Re: How to keep Reviewed-by lines in git commits with gerrit.

[Florian Weimer <fw at deneb dot enyo dot de>]

* Jonathan Nieder:

> Florian Weimer wrote:
>> * Jonathan Nieder:
>
>>>>> I would prefer it to be automatically added by the review tool, as
>>>>> gerrit is designed to do.
>>>>
>>>> Is it?
>>>
>>> The Cherry Pick and Rebase Always submit strategies[1] automatically
>>> add Reviewed-by footers.
>>>
>>> Other submit strategies (like Merge If Necessary) are designed to not
>>> touch the change uploader's commit (e.g. they may have signed it) so
>>> they don't add the footer.
>>
>>> [1]
>>> https://gerrit-review.googlesource.com/Documentation/concept-changes.html#submit-strategies
>>
>> I'm confused.  Is it expected that these changes are not visible in
>> the commits I can download (under the DOWNLOAD button) or in the web
>> UI?  Are they added only during the push?
>
> They are added at submit time, after the review.  At that point, they
> show up as one final patch set.  See
> https://chromium-review.googlesource.com/c/chromium/src/+/1900995 for
> an example.  (The Cr-Commit-Position comes from a chromium-specific
> plugin.)
>
> You can use
> https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#submit-preview
> to preview it, though that's a bit fussy.

Ah, it wasn't clear to me if that was auto-generated.  Then it would
indeed help to enable push-to-sourceware for further tests.

I would like to see how Adhemerval's hppa pthread.h series moves
through review.  I will have further comments then.